Florian Müllner [Thu, 1 Feb 2024 19:37:45 +0000 (20:37 +0100)]
dbusErrors: Don't generate enums
Generating the enums from a list of names means that developers
have to deduce the names of enum members themselves. That's more
important than a bit more convenience when adding a new enum, so
instead spell out the exported enums, and use the enums directly
when registering a domain.
Keyu Tao [Mon, 25 Sep 2023 11:42:31 +0000 (19:42 +0800)]
windowManager: Add "opacity: 0" to minimize ease animation
Extensions like dash-to-dock use set_icon_geometry() to window.
This changes the dest and scale of ease animation of minimize and
makes it looks very strange. By setting dest opacity to 0 the animation
could be more natural.
Florian Müllner [Tue, 30 Jan 2024 18:56:42 +0000 (19:56 +0100)]
screenshot: Split out disabling cast button
Screencasts can be disabled for various reasons:
1. the service is not available (missing plugin etc.)
2. screencasts are not allowed by the session mode
(lock screen etc.)
3. the UI is invoked in screenshot-only mode (portal)
Currently each of those conditions is handled in a different
code path, which means that later conditions can re-enable
the button.
There's also an inconsistency whether disabling the button
is done via visibility or reactivity, which still allows
toggling the hidden button via shortcuts (although a hidden
button means that screencasts aren't supported at all, so
nothing will be recorded in that case).
Address this by updating the button from a dedicated function.
Fixes: 671df28a50 ("screenshot: Only handle mode-switch shortcut when
supported")
Florian Müllner [Wed, 31 Jan 2024 15:28:24 +0000 (16:28 +0100)]
dbusErrors: Add utility module for handling remote errors
We sometimes return custom D-Bus errors. Right now those errors
are ad-hoc, which means receivers don't have a proper way of
checking whether a thrown GLib.Error corresponds to a particular
remote error.
In order to change that, we should define proper error enums and
domains, and register them with GDBus, so that there is an automatic
mapping between D-Bus errors and GLib.Errors.
The new module doesn't export any domains or enums yet, but provides
internal tooling to make these exports more convenient.
Florian Müllner [Wed, 31 Jan 2024 15:16:04 +0000 (16:16 +0100)]
dbusService: Don't double-wrap remote errors
Returning a GLib.Error from a method invocation will encode the
error when sent over the wire. In case the error itself is already
an encoded remote error, just passing it on will result in double
wrapping.
Avoid that by stripping any remote error information before
returning it.
Florian Müllner [Tue, 30 Jan 2024 16:27:32 +0000 (17:27 +0100)]
ci: Do not create pipelines for branches with open MRs
Pipelines for non-protected branches are set to 'manual', and
thus cheap. However they may still get picked by `@marge-bot`,
meaning that the bot waits for the completion of a pipeline that
never starts.
Avoid that by not creating pipelines for branches with open
merge requests.
This object contains only the `title` and `icon` of a
`MessageTray.Source` which allows using it for sources
that aren't notification sources like mpris.
The old `MessageTray.Source` isn't renamed to something
less generic to not break API. Once we have a good reason
we should rename it to something more specific.
Julian Sparber [Thu, 25 Jan 2024 20:11:50 +0000 (21:11 +0100)]
FdoNotifications: Only set the title of a Source once
Even though the comment in the code says that sources are reused even
thought the app title has changed this is actually not the case. Therefore
when ever the app title of a notification changes a new `Source` is
created. Therefore there is no point in setting the app title again.
Julian Sparber [Thu, 25 Jan 2024 16:54:09 +0000 (17:54 +0100)]
telepathyClient: Stop displaying presence in notification
The presence indicator in notification uses API only needed for the
telepathyClient, since it's a complete fringe feature nowadays it's not
worth maintaining specific API for it.
Suryashankar Das [Fri, 12 Mar 2021 19:49:10 +0000 (01:19 +0530)]
overview: Hide search results while leaving overview
There is currently no proper transition from search results
to the session: Only the top bar fades, but the rest of the
screen just changes abruptly at the end of the transition.
Fix this by hiding search results before leaving the overview,
so the regular transition can take place.
Close https://gitlab.gnome.org/GNOME/gnome-shell/-/issues/3821
Jonas Dreßler [Sat, 13 Feb 2021 15:16:20 +0000 (16:16 +0100)]
main: Only restore key focus on pop when modal actor is still focused
If something grabs the key focus while a modal is pushed, keeping
key-focus on that actor seems like the smarter thing to do than setting
it back to the last focus after the modal gets popped again. So check if
the key focus actor that we set when pushing the modal got changed when
popping that modal, and if it got changed, simply don't touch key focus.
This fixes a bug with the close dialog, where key focus isn't correctly
set to the dialog after alt-tabbing to a window showing a close dialog.
Carlos Garnacho [Mon, 29 Jan 2024 15:18:31 +0000 (16:18 +0100)]
st: Do not use markup in button labels
It sounds strange that buttons would admit Pango markup
in their label text. It sounds better to default to plain
text, and let users wanting markup to access the child
directly.
This also makes the first label being set consistent
with later text being assigned wrt markup usage, since
the non-markup ClutterText API is used if the child is
already present and of the expected type.
Florian Müllner [Mon, 29 Jan 2024 20:12:44 +0000 (21:12 +0100)]
windowManager: Keep dim effect in overview
Removing the effect dates back to the time when we didn't show
attached dialogs in the overview. Since we do show attached
dialogs as such nowadays, it makes sense to keep the effect.
Close https://gitlab.gnome.org/GNOME/gnome-shell/-/issues/6265
Florian Müllner [Wed, 17 Jan 2024 04:52:10 +0000 (05:52 +0100)]
docs: Expand contribution section in README
Provide a link to the relevant handbook section and some guidance
for submitting a successful merge request, instead of just throwing
two links at the user.
Florian Müllner [Wed, 17 Jan 2024 02:54:29 +0000 (03:54 +0100)]
docs: Add section on feature requests
Small and well-defined feature requests can be very useful, but
unfortunately too many are neither small nor well-defined.
Try to improve on that by adding another README section that
explains that changes need design approval, and points to
appropriate places to have broader design discussions,
hopefully without being too off-putting.
While this is unlikely to stop all "bad" feature requests, it
at least gives us something to point to when closing requests.
Florian Müllner [Wed, 17 Jan 2024 02:38:52 +0000 (03:38 +0100)]
docs: Elaborate on issue reporting
We currently just link to the issue tracker without providing
any further guidance.
Improve on that by pointing to the appropriate handbook chapter,
point out extensions as a possible source of issues, and direct
users towards discourse/matrix for support/discussions.
Florian Müllner [Tue, 16 Jan 2024 18:43:31 +0000 (19:43 +0100)]
docs: Elaborate on supported versions
The link to the GNOME schedule was added because of some confusion
of which versions are supported upstream. Briefly outline the
policy of "last two stable + current main", so that the information
can also be deduced from tags etc. without scrolling through the
schedule calendar.
While at it, update the link to the schedule to point to the
future release.gnome.org page.
Florian Müllner [Tue, 16 Jan 2024 00:54:56 +0000 (01:54 +0100)]
docs: Split commit message conventions from README
We currently only have a very brief outline of the commit message
conventions in the README.
Improve on that by splitting out the relevant section into a separate
file that outlines all conventions we use in addition to the general
guidelines in the [handbook].
Florian Müllner [Wed, 17 Jan 2024 09:36:10 +0000 (10:36 +0100)]
docs: Add debugging information
The current debugging page on the wiki is fairly outdated and
very X11-centric, so base the new page on the recently added
mutter documentation instead, but with a bigger focus on
Javascript debugging.
Florian Müllner [Tue, 16 Jan 2024 22:42:31 +0000 (23:42 +0100)]
docs: Document C coding style
We have a fair bit of C code, yet don't document the expected
coding style. This is not much of an issue for regular GNOME
contributors as we are following the conventions of the wider
project (glib, gtk, clutter, ...), but it's still better to
spell it out.
Do that by adapting the corresponding documentation from mutter.
Even if much of our C code doesn't match all the new guidelines,
it's good to consolidate the coding style between both projects.
Florian Müllner [Tue, 16 Jan 2024 19:03:03 +0000 (20:03 +0100)]
docs: Use dashes in filenames
Mutter's documentation was extended recently, with files using a
pattern of `some-stuff.md`. There is no strong argument for using
camel case, so switch to the same pattern as mutter to remove some
unnecessary friction for people who contribute to both projects.
Florian Müllner [Thu, 25 Jan 2024 23:56:35 +0000 (00:56 +0100)]
ci: Check snippets in coding style
To avoid having the coding style get out of sync with the actual
coding style in the future, run eslint on the individual snippets
when either the guide or the linter config change.
Florian Müllner [Thu, 25 Jan 2024 22:15:42 +0000 (23:15 +0100)]
doc: Fix style errors in coding style
As we've adapted our coding style, the corresponding documentation
hasn't always caught up. Fix the errors that eslint would point
out if it checked the code snippets.
Florian Müllner [Tue, 23 Jan 2024 22:40:04 +0000 (23:40 +0100)]
iconGrid: Don't recreate StIcons on icon theme changes
Now that StIcon updates its texture automatically on icon theme
changes, we only have to recreate icon actors that aren't StIcons.
(This probably only applies to the folder icon in the app grid
where the sub-icons do use St.Icon, but making that assumption
feels dodgy with an API as generic as `createIcon()`)
Florian Müllner [Tue, 23 Jan 2024 20:20:51 +0000 (21:20 +0100)]
st/icon: Automatically update on icon theme changes
St.Icon is very commonly used for displaying themed icons, yet so
far updating the icon on icon theme changes is left to the caller.
Unsurprisingly, very few actually do that, with the result that
for most icons, icon theme changes only take effect after a delay
(say, a color change on hover) or not at all.
This is also inconsistent with GTK, where Gtk.Image will automatically
pick up icon theme changes.
Address this by tracking whether the current icon corresponds to
a themed icon, and update it automatically on theme changes if
it does.
Sam Hewitt [Mon, 15 Jan 2024 16:59:26 +0000 (13:29 -0330)]
calendar: Stylesheet clean up & fixes
- added style class for when there are no world clocks present
- restructured the scss to match the widget structure
- cleaned up padding and font color styles
- improved high contrast support
Florian Müllner [Sun, 21 Jan 2024 17:50:54 +0000 (18:50 +0100)]
tests: Fix check for global scope pollution
Since commit c570011 dropped the `with` statement, this bit of
the test has only checked for writes to a specific variable
in the file.
There is no direct replacement for `with` here, the best we can
do (I think) is comparing property names on the global objects
before and after the `eval()` call.
Sam Hewitt [Mon, 15 Jan 2024 15:19:40 +0000 (11:49 -0330)]
dash: Resolve padding and alignment issues with dash items
- revert a change to y-expand on dash items
- clean up the manual padding on dash items in stylesheet
- fix an issue with the running dot being misaligned
Florian Müllner [Fri, 19 Jan 2024 12:35:53 +0000 (13:35 +0100)]
panel: Remove unnecessary code
Since commit a4660293748, the activities button uses the standard
`:checked` pseudo class in the overview instead of the custom
`:overview`.
As a side effect, the generic handling of the `CHECKED` Atk state
in StWidget now covers the case, and we no longer need to manage
the state explicitly.
Robert Mader [Thu, 18 Jan 2024 13:14:55 +0000 (14:14 +0100)]
tests/build: Silence meson deprecation warning
This produced the following warning:
```
DEPRECATION: Project uses feature that was always broken, and is now
deprecated since '1.3.0': str.format: Value other than strings,
integers, bools, options, dictionaries and lists thereof..
```
The resulting value of `SHELL_BACKGROUND_IMAGE` was indeed bogus, not
containing a proper file path.
projects / gnome-shell.git / log